Fix PIP mode orientation #160
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps androidx.appcompat:appcompat from 1.6.1 to 1.7.0. --- updated-dependencies: - dependency-name: androidx.appcompat:appcompat dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps androidx.test.espresso:espresso-core from 3.5.1 to 3.6.1. --- updated-dependencies: - dependency-name: androidx.test.espresso:espresso-core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…f the app orientation.
|
Hi, |
|
I changed a lot of things for the v3. Could you give a try on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When app is in PIP mode, it is possible that the device is in different orientation than the app. In this case the stream is of wrong aspect ratio and rotation. I fixed this problem in my app by changing the Context.isDevicePortrait to actually give device orientation instead of application orientation (since orientation provider otherwise uses the device orientation).
On the implementation:
Display.getRotation() gives the rotation from the "natural" orientation of the device so my code tries to figure out the natural orientation of the device from its physical size. I don't have a device with natural orientation of landscape so I can't be sure it works on those devices.