Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change specific version (4.4.1) of github-pages-deploy-action to v4.5.0 #120

Merged
merged 5 commits into from
Mar 22, 2024

Conversation

francisbarton
Copy link
Collaborator

@francisbarton francisbarton commented Mar 12, 2024

Ref issue #119.

Automated pkgdown run after commit (via GitHub Actions) currently generates a warning (not an error) about moving from Node 16 to Node 20.
I believe this is addressed by moving the JamesIves/github-pages-deploy-action version up from the current v4.4.1 to the latest (v4.5.0).

Edit: no, this also needed a move to actions/checkout@v4 across both pkgdown (gh pages deploy) and cmd check Actions.

This PR:

  • updates the "GH Pages deploy" Action YAML file
  • updates the "check release" (CMD check) Action YAML file (using usethis::use_github_action("check-release"))

Please confirm that you have:

  • Run devtools::test() and fixed all failing tests and warnings.
  • Added suppressMessages() to any test message which breaks the test progress UI.

@francisbarton francisbarton changed the title Change specific version (4.4.1) of github-pages-deploy-action to generic @v4 Change specific version (4.4.1) of github-pages-deploy-action to v4.5.0 Mar 12, 2024
@francisbarton
Copy link
Collaborator Author

Can confirm that following edits to the .yaml files, the Actions now run without generating the Node version message.

@francisbarton francisbarton linked an issue Mar 12, 2024 that may be closed by this pull request
Copy link
Owner

@ThomUK ThomUK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Fran

@ThomUK ThomUK merged commit b883084 into main Mar 22, 2024
2 checks passed
@ThomUK ThomUK deleted the issue_119 branch March 22, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkgdown github action error
2 participants