Fix "target set by" box not displaying; remove some logic from Rmd details template #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
March 12, 2024 09:18
…ightly differently
VSCode workspace files don't need to be committed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please complete the following information:
A reference to the issue addressed by this pull-request:
A description of the changes proposed in this PR:
Add @mentions for the people who will review this PR:
This PR is in response to issue #121 (see also issue #98).
Changes related to this issue have been rebased onto branch
issue_117for report production purposes, so this PR incorporates the commits on that branch as well. If PR #118 is merged intomainin advance, this PR should become much "smaller".This PR:
calculate_stale_data()from a logical (TRUE/FALSE) to a string ("stale"/"fresh"). So it can be used directly in the Rmd as a CSS class name. The logical value wasn't being consumed elsewhere in the package as far as I can seecalculate_stale_data()is now vectorised and happens within the make bundle step instead of in the make report step (test expectations have been tweaked in response)geom_annotate()step instead of ageom_point, as the use of geom_point() was generating a warning message on render.@ThomUK please review.
Please confirm that you have:
devtools::test()and fixed all failing tests and warnings.suppressMessages()to any test message which breaks the test progress UI.