Fixed infinite loop on truncated file

ThoughtSynth · Aug 28, 2015 · a0d38a3 · a0d38a3
1 parent cc19ca4
commit a0d38a3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/PIL/PpmImagePlugin.py b/PIL/PpmImagePlugin.py
@@ -93,6 +93,8 @@ def _open(self):
                     s = self.fp.read(1)
                     if s not in b_whitespace:
                         break
+                    if s == b"":
+                        raise ValueError("File does not extend beyond magic number")
                 if s != b"#":
                     break
                 s = self.fp.readline()

diff --git a/Tests/test_file_ppm.py b/Tests/test_file_ppm.py
@@ -35,6 +35,14 @@ def test_16bit_pgm_write(self):
         reloaded = Image.open(f)
         self.assert_image_equal(im, reloaded)
 
+    def test_truncated_file(self):
+        path = self.tempfile('temp.pgm')
+        f = open(path, 'w')
+        f.write('P6')
+        f.close()
+
+        self.assertRaises(ValueError, lambda: Image.open(path))
+
 
 if __name__ == '__main__':
     unittest.main()