Minor bugfixes for channel link parsing and chat tab state handling (#97

)
TicClick · Feb 20, 2024 · 7d20eda · 7d20eda
1 parent 7450586
commit 7d20eda
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 13 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/crates/steel_core/Cargo.lock b/crates/steel_core/Cargo.lock
diff --git a/crates/steel_core/Cargo.toml b/crates/steel_core/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "steel_core"
-version = "0.1.4"
+version = "0.1.5"
 edition = "2021"
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

diff --git a/crates/steel_core/src/chat/links.rs b/crates/steel_core/src/chat/links.rs
@@ -221,13 +221,16 @@ impl Message {
             // Channel name.
             if i < bs.len() && bs[i] == b'#' {
                 i += 1;
-                while i < bs.len() && b'a' <= bs[i] && bs[i] <= b'z' {
+                while i < bs.len() && ((b'a' <= bs[i] && bs[i] <= b'z') || bs[i] == b'_') {
                     i += 1;
                 }
-                links.push(LinkLocation::Raw {
-                    pos: (start, i),
-                    protocol: LinkType::Channel,
-                });
+                // '#' is an invalid channel name -- skip it.
+                if i > start + 1 {
+                    links.push(LinkLocation::Raw {
+                        pos: (start, i),
+                        protocol: LinkType::Channel,
+                    });
+                }
                 continue;
             }
 

diff --git a/src/gui/mod.rs b/src/gui/mod.rs
@@ -76,14 +76,14 @@ impl DecoratedText for &str {
 }
 
 pub fn validate_username(input: &str) -> Result<(), &'static str> {
-    match input.contains(|ch: char| !ch.is_ascii_alphanumeric() && !"-_ []".contains(ch)) {
+    match input.contains(|ch: char| !(ch.is_ascii_alphanumeric() || "-_ []@".contains(ch))) {
         true => Err("invalid username"),
         false => Ok(()),
     }
 }
 
 pub fn validate_channel_name(input: &str) -> Result<(), &'static str> {
-    match input.contains(|ch: char| !ch.is_ascii_alphanumeric() && ch != '#') {
+    match input.contains(|ch: char| !(ch.is_ascii_alphanumeric() || ch == '#' || ch == '_')) {
         true => Err("invalid channel name"),
         false => Ok(()),
     }

diff --git a/src/gui/window.rs b/src/gui/window.rs
@@ -236,9 +236,9 @@ impl ApplicationWindow {
                 }
 
                 UIMessageIn::ChatSwitchRequested(name, message_id) => {
+                    let lowercase_name = name.to_lowercase();
+                    self.s.highlights.mark_as_read(&lowercase_name);
                     if self.s.has_chat(&name) {
-                        let lowercase_name = name.to_lowercase();
-                        self.s.highlights.mark_as_read(&lowercase_name);
                         self.s.active_chat_tab_name = lowercase_name;
                         if message_id.is_some() {
                             self.chat.scroll_to = message_id;