Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<GLFW>: Adding the static library #48

Draft
wants to merge 41 commits into
base: main
Choose a base branch
from
Draft

<GLFW>: Adding the static library #48

wants to merge 41 commits into from

Conversation

BrandonPacewic
Copy link
Member

@BrandonPacewic BrandonPacewic commented Jul 27, 2022 •
edited
Loading

PR Info

Closes #46.
Closes #47.

Connected #31.

The goal was to also do the same for #49 however only the Linux version of this error was solved.

Changes

Adds the glfw .a file (a static library file). This way we don't need to worry about compiling the glfw project everything we need is already there.

Please keep in mind that you will still need glfw on your local machine.

Basic build instructions are now on the README.

Maintainer Notes

⚠️ Do not delete this section. Checklist for maintainers.

IMPORTANT: Complete the following checklist before merging.

  • All PR's should be added to the Code Reviews project page.
  • Once you are happy with the changes remove the do not merge for the ready to merge tag.
  • Commits should be Squashed and Merged.

@BrandonPacewic
Added submodule
5c11c5e
@BrandonPacewic
Working submodule
2f955f9
@BrandonPacewic
Added the subdirectory
e80aac6
@BrandonPacewic
Trying new things
767248e
@BrandonPacewic
Trying new things
51fca87
@BrandonPacewic
Changed compiler path for linux
ee67e18
@BrandonPacewic
Glfw static library + test harness
8b568cc
@BrandonPacewic
Update to window test
19c1b78
@BrandonPacewic
Deledet test test file
1ef6cb7
@BrandonPacewic
Update to window class and test
2680f92
@BrandonPacewic
Removed set to build testing
8f50900
@BrandonPacewic
Merge pull request #1 from BrandonPacewic/glfw-submodule
f4890f7 
Glfw submodule
@BrandonPacewic
Update to build test runner (#2)
a444319
@BrandonPacewic
Update README.md
8fde6e7
@BrandonPacewic
Update to build testing workflow
3f7842d
@BrandonPacewic
Update README.md
9d36d83
@BrandonPacewic
Update to build testing workflow
6b33378
@BrandonPacewic
Merge branch 'main' of https://github.com/BrandonPacewic/Ionic into main
92eea71
@BrandonPacewic
Update to build testing workflow
c4dbebb
@BrandonPacewic
Update README.md
8bef93e
@BrandonPacewic
Update to build testing workflow
65d7ce7
@BrandonPacewic
Merge branch 'main' of https://github.com/BrandonPacewic/Ionic into main
5042f87
@BrandonPacewic
Update README.md
39b7fda
@BrandonPacewic
Update to build testing workflow
05cc9fd
@BrandonPacewic
Merge branch 'main' of https://github.com/BrandonPacewic/Ionic into main
0f9c794
@BrandonPacewic
Update to test cmake file
d39e9b2
@BrandonPacewic
Update to build testing dependencies
d56f15b
@BrandonPacewic
Update build-testing.yml
ba4153b
@BrandonPacewic
Update to window class and build testing workflow
cc0f6b7
@BrandonPacewic
Update to testing workflow
6c087f2
@BrandonPacewic BrandonPacewic requested a review from Galaxy25 as a code owner July 27, 2022 19:37
@github-actions github-actions bot added change-sent-to-author The author has been notified about your change cmake core do-not-merge Your change is waiting to be reviewed md A markdown problem test A test feature add or problem waiting-for-review A reviewer is going to review your change soon! labels Jul 27, 2022
@BrandonPacewic BrandonPacewic marked this pull request as draft July 27, 2022 19:38
@BrandonPacewic
Copy link
Member Author

Please make sure that everything works for you before we merge, want to get it right this time.

The code is on my fork of the repository here.

If you run into any problems that you can't fix after a while we can setup another meeting to work through them together.

Good luck! @Galaxy25

@BrandonPacewic BrandonPacewic mentioned this pull request Jul 29, 2022
Open
@BrandonPacewic
Copy link
Member Author

Please keep in mind that this is only a valid fix for Linux. Windows linking is still broken as of this moment.

@BrandonPacewic BrandonPacewic added the linux Linux problem/fix label Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Galaxy25 Galaxy25 Awaiting requested review from Galaxy25 Galaxy25 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@Galaxy25 Galaxy25

Labels
change-sent-to-author The author has been notified about your change cmake core do-not-merge Your change is waiting to be reviewed linux Linux problem/fix md A markdown problem test A test feature add or problem toolset waiting-for-review A reviewer is going to review your change soon!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the <GLFW> library binary <GLFW>: CMake fails to find X11 required dependency
2 participants
@BrandonPacewic @Galaxy25