-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 1.21 support #34
base: master
Are you sure you want to change the base?
Conversation
Hello, we are using this version on my server. Could you please update it to also support 1.21.1? Would be very much appreciated, thank you. |
@WhatsTheBadNews let me know if this works for you |
@OakLoaf Thank you for replying I've just tested it out and it seems like there is a LOT of console spam: https://mclo.gs/MA6KFmY |
Ohh, that's annoying, I hoped it wouldn't require other changes as the protocol version didn't change. There might just have been something else I overlooked. I'll try to fix it at somepoint when I have free time. |
Check NMSSupport.java getBodyRotationField you will find its retruning "aV" and not "aY" |
I haven't looked at all yet personally I'm afraid, my initial support for 1.21.1 was just done via the GitHub editor in hopes that no methods had changed as the protocol version hadn't changed |
I've just checked the MiniMappingViewer and yBodyRot is still "aY" https://minidigger.github.io/MiniMappingViewer/#/mojang/client/1.21.1/LivingEntity |
Ahh actually I see what you mean, I misunderstood |
@WhatsTheBadNews this version should hopefully resolve the issue, though this is still untested by me |
I've added support for 1.21.2, this is untested but let me know if there are any issues |
I'm sorry to bother you. Could you help me? This is a very good plugin, but it is not officially updated. As I understand it, you were able to upgrade it, and now it supports newer versions. Since I do not understand the writing of plugins and their inner workings, I ask for your help. Is there such an opportunity to get ready .jar file, just to install it on the server. |
These changes break support for old versions due to particle enum changes.