Standardize on sentence case #1865
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CendioOssman
requested changes
Nov 4, 2024
LICENCE.TXT
Outdated
| @@ -279,7 +279,7 @@ POSSIBILITY OF SUCH DAMAGES. | |||
|
|
|||
| END OF TERMS AND CONDITIONS | |||
|
|
|||
| Appendix: How to Apply These Terms to Your New Programs | |||
| Appendix: How to apply these terms to your new programs | |||
There was a problem hiding this comment.
This file is a verbatim copy from FSF and such is best left alone.
common/rfb/Congestion.cxx
Outdated
| @@ -21,7 +21,7 @@ | |||
| * order to avoid excessive latency in the transport. This is needed | |||
| * because "buffer bloat" is unfortunately still a very real problem. | |||
| * | |||
| * The basic principle is TCP Congestion Control (RFC 5618), with the | |||
| * The basic principle is TCP Congestion control (RFC 5618), with the | |||
There was a problem hiding this comment.
This is the title of the RFC, and might be best left as title case.
(the RFC number seems wrong, though)
unix/x0vncserver/XDesktop.cxx
Outdated
| @@ -71,7 +71,7 @@ BoolParameter rawKeyboard("RawKeyboard", | |||
| "avoid mapping them to the current keyboard " | |||
| "layout", false); | |||
| IntParameter queryConnectTimeout("QueryConnectTimeout", | |||
| "Number of seconds to show the Accept Connection dialog before " | |||
| "Number of seconds to show the Accept connection dialog before " | |||
There was a problem hiding this comment.
Do we need quotes or something here now that it is less clear what is the title it is referring to?
Or perhaps rephrase it so it doesn't have to perfectly match the title?
common/rdr/RandomStream.cxx
Outdated
| @@ -69,7 +69,7 @@ RandomStream::RandomStream() | |||
| { | |||
| #endif | |||
| #endif | |||
| vlog.error("no OS supplied random source - using rand()"); | |||
| vlog.error("No OS supplied random source: Using rand()"); | |||
There was a problem hiding this comment.
A comma suggests an explanation or more details. Perhaps a comma if the dash is undesirable?
vncviewer/Viewport.cxx
Outdated
| @@ -260,7 +260,7 @@ void Viewport::setCursor(int width, int height, const Point& hotspot, | |||
| if (data[i*4 + 3] != 0) break; | |||
|
|
|||
| if ((i == width*height) && dotWhenNoCursor) { | |||
| vlog.debug("cursor is empty - using dot"); | |||
| vlog.debug("Cursor is empty: Using dot"); | |||
win/rfb_win32/CleanDesktop.cxx
Outdated
| @@ -166,7 +166,7 @@ void CleanDesktop::disableWallpaper() { | |||
| try { | |||
| ImpersonateCurrentUser icu; | |||
|
|
|||
| vlog.debug("disable desktop wallpaper/Active Desktop"); | |||
| vlog.debug("Disable desktop wallpaper/active desktop"); | |||
There was a problem hiding this comment.
"Active Desktop" is actually a brand name
win/rfb_win32/CleanDesktop.cxx
Outdated
| @@ -191,7 +191,7 @@ void CleanDesktop::enableWallpaper() { | |||
| ImpersonateCurrentUser icu; | |||
|
|
|||
| if (restoreActiveDesktop) { | |||
| vlog.debug("restore Active Desktop"); | |||
| vlog.debug("Restore active desktop"); | |||
The reason for this is to keep a consistency through out the project.
The reason for this is to keep a consistency through out the project.
The reason for this is to keep a consistency through out the project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fixes to both titles as well as for log messages, exceptions and errors.