Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI for #768 #770

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Fix CI for #768 #770

merged 1 commit into from
Oct 17, 2024

Conversation

johnkerl
Copy link
Collaborator

@johnkerl johnkerl commented Oct 17, 2024 •
edited
Loading

On #768 I used expect_no_condition which is valid in testthat but not in tinytest

For #769 and TileDB-Inc/centralized-tiledb-nightlies#24 (comment)

This was referenced Oct 17, 2024
Closed
Open
@johnkerl johnkerl merged commit a9aaa58 into main Oct 17, 2024
8 checks passed
@johnkerl johnkerl deleted the kerl/tinytest-fixup branch October 17, 2024 22:53
@johnkerl
Copy link
Collaborator Author

Thanks @ihnorton and @mojaveazure ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihnorton ihnorton ihnorton approved these changes

@jdblischak jdblischak jdblischak approved these changes

@mojaveazure mojaveazure mojaveazure approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johnkerl @ihnorton @jdblischak @mojaveazure