Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add switch for variant stats array version #720

Merged
merged 5 commits into from
May 15, 2024

Conversation

awenocur
Copy link
Contributor

No description provided.

@awenocur awenocur requested a review from gspowley May 14, 2024 06:41
@awenocur awenocur marked this pull request as ready for review May 14, 2024 08:41
Copy link
Member

@gspowley gspowley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

A couple of comments about the sample buffer for v2.

apis/python/src/tiledbvcf/binding/writer.h Outdated Show resolved Hide resolved
libtiledbvcf/src/stats/variant_stats.cc Outdated Show resolved Hide resolved
libtiledbvcf/src/stats/variant_stats.cc Outdated Show resolved Hide resolved
@awenocur awenocur force-pushed the adamwenocur/sc-46749/stats_version branch 2 times, most recently from 915638e to eea3914 Compare May 15, 2024 02:47
@awenocur awenocur merged commit 02621c1 into main May 15, 2024
13 checks passed
@awenocur awenocur deleted the adamwenocur/sc-46749/stats_version branch May 15, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants