-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hail-like AC, AN, and AF computation to variant stats V3 #731
Conversation
280e2a5
to
e48d907
Compare
37ccc76
to
94398da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will take multiple passes to review. Here's the first.
a7b2da6
to
2e447c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would expect some tests in here that are human readable. right now all I see if df.shape
.
2e447c3
to
94bcb60
Compare
f1c10e4
to
c7be7cf
Compare
This reverts commit 81eda28.
3ef786b
to
568f0d5
Compare
3311242
to
b2fd97a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Let's resolve the offline conversation before merging.
return normalized_ref + "," + normalized_alt; | ||
} | ||
|
||
std::string VariantStats::alt_string_v3(char* ref, char* alt) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a difference in alt_string
and alt_string_v3
?
Take ref blocks into account when computing AF, and make two new fields:
info_TILEDB_IAC
andinfo_TILEDB_IAN
available to data frames.