Disable consolidate_update_fragments for TileDB Cloud URIs #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[sc-56613] |
ypatia
approved these changes
Oct 1, 2024
ihnorton
approved these changes
Oct 1, 2024
| @@ -800,6 +800,10 @@ def _set_has_updates(self, has_updates: bool = True): | |||
| self.group = tiledb.Group(self.uri, "r", ctx=tiledb.Ctx(self.config)) | |||
|
|
|||
| def _consolidate_update_fragments(self): | |||
| # Disable update fragment consolidation for TileDB Cloud URIs | |||
| # as this is not supported. | |||
| if self.uri.startswith("tiledb://"): | |||
There was a problem hiding this comment.
IMO we should log a message here (once only) at a low threshold (debug level).
There was a problem hiding this comment.
Added a warning for this
NikolaosPapailiou
deleted the
npapa/tiledb_consolidate_update_fragments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable
_consolidate_update_fragmentsfor TileDB Cloud URIs.Fragment consolidation is not supported in TileDB Cloud.