Add start, stop, and temporal_policy to FeatureVector and FeatureVectorArray #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikolaosPapailiou
approved these changes
Oct 15, 2024
| py::arg("ctx"), | ||
| py::arg("uri"), | ||
| py::arg("first_col") = 0, | ||
| py::arg("first_col") = 0, |
There was a problem hiding this comment.
Thanks, done.
| }, | ||
| py::keep_alive<1, 2>(), // FeatureVectorArray should keep ctx alive. | ||
| py::arg("ctx"), | ||
| py::arg("uri"), | ||
| py::arg("ids_uri") = "", | ||
| py::arg("num_vectors") = 0, | ||
| py::arg("first_col") = 0, | ||
| py::arg("first_col") = 0, |
There was a problem hiding this comment.
Thanks, done.
| ctx, | ||
| parts_array_uri, | ||
| ids_array_uri, | ||
| 0, |
There was a problem hiding this comment.
For better readability, it would be nice to follow the pattern bellow for such arguments
data = vspy.FeatureVectorArray(
ctx,
parts_array_uri,
ids_array_uri,
/* first_col */ 0,
/* last_col */ 0,
to_temporal_policy(index_timestamp),
)
There was a problem hiding this comment.
Sure, thanks, done (though note it's a little different than this b/c a Python comment).
…arch into jparismorgan/feature-vector-and-array-start-stop
jparismorgan
deleted the
jparismorgan/feature-vector-and-array-start-stop
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add
start,stop, andtemporal_policytoFeatureVectorandFeatureVectorArray. This will let us callingest_parts()on batches of vectors from Python for the new IVF_PQ out-of-core work.Testing