Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce IsZero trait for is_zero() #503

Merged
merged 1 commit into from
May 28, 2024

Conversation

frankmcsherry
Copy link
Member

This extracts is_zero() from Semigroup, which now requires it instead. The reasoning is that while Semigroup<Rhs> can have multiple Rhs implementations, there cannot be multiple is_zero() implementations, and we want to avoid confusion there. In fact, it isn't especially clear what being a zero means for any other Rhs, and we don't really end up using is_zero() in support of semigroup actions as much as once accumulation has been accomplished, determining whether to discard the update or not.

@frankmcsherry frankmcsherry merged commit 6ce91f1 into TimelyDataflow:master May 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants