Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Abelian::negate() act on borrowed data #504

Merged
merged 1 commit into from
May 28, 2024

Conversation

frankmcsherry
Copy link
Member

Abelian::negate() took a self argument, which meant that in several cases it provoked a clone() call that wasn't strictly necessary. The negate() dataflow operator, for example, would simply clone the diff in order to negate it, which is fine for isize but less great for Vec<Diff> types.

@frankmcsherry frankmcsherry merged commit 83796a9 into TimelyDataflow:master May 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant