Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix index range error and refactor get_training_batch method #133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix index range error and refactor get_training_batch method #133

wants to merge 1 commit into from

Conversation

lnfu
Copy link

@lnfu lnfu commented Oct 1, 2024

  • Corrected the index range check from (len(self.training_indices) + 1) to avoid potential out-of-bounds errors.
  • Eliminated unnecessary length checks.

Fix index range error and refactor get_training_batch method
5875fdd 
- Corrected the index range check from (len(self.training_indices) + 1) to avoid potential out-of-bounds errors, which was theoretically problematic.
- Refactored the logic for updating the current state to improve readability.
- Simplified batch index calculation and eliminated unnecessary length checks, addressing edge cases more robustly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lnfu