-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow unsetting boolean configs #358
Conversation
Updated man page. Also added some non-documented parameters. @VictorDenisov would it be OK to rename |
Yeah. Totally. I guess now the configuration will look like |
Yes. Any of these statements will suppress leading zeros.
(the argument is case-insensitive, so |
Code looks good and should catch all needed use cases. I think we should merge it in. To drop keywords with negative logic (e.g. NO_BANDSWITCH_ARROWKEYS) it seems we need to document the default value of the boolean values in the man page. It seems further desirable to have a command to show the state of the boolean controls in the running program. But both may be later additions. |
I'd keep legacy negative logic parameters. It would be more work to document such a change than the actual benefit. But at least for new configs we shall stick to positive logic. Showing (and editing + reloading) configs is related to #233: one idea could be to move all globals and their initialization out of main into a data.c (like for the tests). But this is also more for the future. |
I agree to both. They are ideas for the long run. |
See #357.
Minor extension: on/off are also treated as true/false.
Man page update will follow when code is OK. (will have to update a lot of params...)