Fix scoring #390
Open
Fix scoring #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was used for control of point scoring. By leaving all point controlling keywords (besides COUNTRYLIST_POINTS) undefined the same result can be achieved.
* Do some further cleanup and * adapt test code
zcsahok
reviewed
Apr 16, 2023
| @@ -2682,10 +2682,6 @@ instead. | |||
| Points for countries in country list. | |||
| . | |||
| .TP | |||
There was a problem hiding this comment.
It would be worth spending an own chapter to scoring. At least to have the basic logic documented.
There was a problem hiding this comment.
True. Points and multiplier scoring needs to be documented. I was undecided if we do it in man page or should use a separate document. As a start the keywords in man page should be sorted and grouped together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework default scoring.
Drop use of USE_COUNTRYLIST_ONLY and USE_CONTINENTLIST_ONLY from point scoring and replace it by clear precedence rules.
Point scoring is now controlled by the following keyword (in falling order):
Keywords not set will be ignored.