Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bare script commands #426

Closed
wants to merge 3 commits into from
Closed

Fix bare script commands #426

wants to merge 3 commits into from

Commits on Feb 20, 2024

  1. Use full path for 'rec' in scripts/soundlog 

    Due to the pattern matching of the '-f' option to 'pkill' in the man
page example, use the full path which should avoid matching the command
line of other processes.  For references see:

https://lists.debian.org/debian-user/2023/08/msg00406.html
https://lists.debian.org/debian-user/2023/09/msg00211.html
https://lists.debian.org/debian-user/2024/02/msg00800.html

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1053923

In short the '-f rec' option matched the '--directory' option of
'gnome-keyring-daemon' and killed it at the top of each hour when
'pkill -f rec' was run.

Modifying the script and man page to use the full path (whatever that
might be, typically '/usr/bin/rec' in Linux but could be elsewhere)
should go along way to helping someone avoid similar pain.
    @N0NB
    N0NB committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    644af22 View commit details
    Browse the repository at this point in the history

  2. Use full path for 'play' in scripts/play_vk 

    Similar to the patch to 'soundlog', use the full path to 'play'.
    @N0NB
    N0NB committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    c426ff5 View commit details
    Browse the repository at this point in the history

  3. Replace backticks with $() in scripts/soundlog 

    As backticks are generally hard to see, use the synonymous $() construct
to generate the name for the audio file.  $() is preferred for capturing
the output of a command into a shell variable.
    @N0NB
    N0NB committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    9e984df View commit details
    Browse the repository at this point in the history