Skip to content

Commit

Permalink
Fix: Support custom dbt project loaders (#3920)
Browse files Browse the repository at this point in the history
  • Loading branch information
izeigerman committed Feb 28, 2025
1 parent b38bc85 commit 44e0180
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 1 deletion.
6 changes: 5 additions & 1 deletion sqlmesh/dbt/loader.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,12 @@ def sqlmesh_config(
if register_comments is not None:
target_to_sqlmesh_args["register_comments"] = register_comments

loader = kwargs.pop("loader", DbtLoader)
if not issubclass(loader, DbtLoader):
raise ConfigError("The loader must be a DbtLoader.")

return Config(
loader=DbtLoader,
loader=loader,
model_defaults=model_defaults,
variables=variables or {},
**{
Expand Down
14 changes: 14 additions & 0 deletions tests/dbt/test_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -901,6 +901,20 @@ def test_connection_args(tmp_path):
assert not config.gateways["in_memory"].connection.register_comments


def test_custom_dbt_loader():
from sqlmesh.core.loader import SqlMeshLoader
from sqlmesh.dbt.loader import DbtLoader

dbt_project_dir = "tests/fixtures/dbt/sushi_test"
with pytest.raises(ConfigError, match="The loader must be a DbtLoader."):
sqlmesh_config(dbt_project_dir, loader=SqlMeshLoader)

class CustomDbtLoader(DbtLoader):
pass

sqlmesh_config(dbt_project_dir, loader=CustomDbtLoader)


@pytest.mark.cicdonly
def test_db_type_to_relation_class():
from dbt.adapters.bigquery.relation import BigQueryRelation
Expand Down

0 comments on commit 44e0180

Please sign in to comment.