Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python38/Windows dll load directory for maint-1.8 #875

Merged
merged 6 commits into from
May 22, 2020
Merged

Python38/Windows dll load directory for maint-1.8 #875

merged 6 commits into from
May 22, 2020

Conversation

rbuffat
Copy link
Contributor

@rbuffat rbuffat commented Apr 4, 2020

I created a clean PR for maint-1.8 based on #852

@coveralls
Copy link

coveralls commented Apr 4, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.3%) to 83.061% when pulling 32a2128 on rbuffat:python38_win_maint_1_8 into e1f0e1b on Toblerity:maint-1.8.

@rbuffat rbuffat mentioned this pull request Apr 20, 2020
Closed
@rbuffat
Copy link
Contributor Author

rbuffat commented Apr 30, 2020

Coveralls is not configured on appveyor and the changes only affect windows.

@sgillies
Copy link
Member

@rbuffat thank you very much!

@sgillies sgillies merged commit a9feeb5 into Toblerity:maint-1.8 May 22, 2020
@sgillies sgillies added this to the 1.8.14 milestone May 22, 2020
@rbuffat
Copy link
Contributor Author

rbuffat commented May 23, 2020

Thanks for reviewing the PR! @sgillies @snorfalorpagus @s7726

@sgillies
Copy link
Member

Resolves #851

@underchemist underchemist mentioned this pull request Mar 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.8.14
Development

Successfully merging this pull request may close these issues.
3 participants
@rbuffat @coveralls @sgillies