Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to java 22 #1071

Draft
wants to merge 14 commits into
base: develop
Choose a base branch
from
Draft

upgrade to java 22 #1071

wants to merge 14 commits into from

Conversation

Taz03
Copy link
Member

@Taz03 Taz03 commented Mar 22, 2024 •
edited
Loading

  • Upgraded Gradle to 8.8
  • Upgraded project Java to version 22
  • Upgraded workflow
  • Used _ instead of any or ignored
  • cat
    image

@Taz03 Taz03 requested a review from a team as a code owner March 22, 2024 18:40
@Taz03 Taz03 self-assigned this Mar 22, 2024
@Taz03 Taz03 added enhancement New feature or request priority: normal labels Mar 22, 2024
@SquidXTV
Copy link
Member

The workflows cannot be on Java 22, because gradle itself doesn't support Java 22 it only supports running code on Java 22.

This is from gradle release notes:- image

but compiling to java 22 works fine right? just not running the daemon with java 22, right?

@Taz03
Copy link
Member Author

Taz03 commented Mar 22, 2024

@SquidXTV Yes, compiling works fine. That's why the tests pass

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Zabuzard
Zabuzard previously requested changes Mar 25, 2024
View reviewed changes
Copy link
Member

@Zabuzard Zabuzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked at least until Adoptium offers Java 22 on the main page (i.e. after official release).

@Taz03 Taz03 marked this pull request as draft March 25, 2024 08:16
@SquidXTV
Copy link
Member

Blocked at least until Adoptium offers Java 22 on the main page (i.e. after official release).

It does right?
https://adoptium.net/temurin/releases/?version=22

@SimonVerhoeven
Copy link
Contributor

It would be nice to see this one merged.

@Taz03 Taz03 removed their assignment Apr 14, 2024
@Zabuzard Zabuzard dismissed their stale review May 23, 2024 08:41

blocking issue has been resolved apparently

@Taz03 Taz03 force-pushed the java-22 branch 5 times, most recently from ef468ff to 2f86aae Compare May 30, 2024 06:51
@SquidXTV
Copy link
Member

SquidXTV commented Jun 1, 2024

gradle 8.8 released so this can be finished

@Taz03
Copy link
Member Author

Taz03 commented Jun 1, 2024

blocked by #1123

@Taz03
Copy link
Member Author

Taz03 commented Jun 6, 2024

Issue related to sonarlint failing https://community.sonarsource.com/t/java-21-unamed-pattern-error/109839

@SquidXTV
Copy link
Member

SquidXTV commented Jun 7, 2024

Issue related to sonarlint failing https://community.sonarsource.com/t/java-21-unamed-pattern-error/109839

It is talking about preview features and java 21. How is this related?

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)
19 New Blocker Issues (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zabuzard Zabuzard Zabuzard left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request priority: normal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Taz03 @SquidXTV @SimonVerhoeven @Zabuzard