Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/npe help thread close #1160

Conversation

ankitsmt211
Copy link
Member

resolve #1157

Before

  • when running archive help thread in DB routine, it would call a method that uses threadChannel inside a try-catch block
  • It would catch Exception outside the method, even tho NPE is triggered inside it.

After

  • refactor method to check of if threadChannel is NULL(if a channel is deleted when routine is triggered)
  • Removes try-catch block
  • conditional logic to handle if thread is NULL

@ankitsmt211 ankitsmt211 self-assigned this Aug 31, 2024
@ankitsmt211 ankitsmt211 requested a review from a team as a code owner August 31, 2024 17:50
@marko-radosavljevic marko-radosavljevic merged commit 4173da4 into Together-Java:develop Sep 27, 2024
9 checks passed
@ankitsmt211 ankitsmt211 mentioned this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NullPointer Exception
3 participants