Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/jshell #870

Merged
merged 9 commits into from
Aug 11, 2023
Merged

Feature/jshell #870

merged 9 commits into from
Aug 11, 2023

Conversation

Alathreon
Copy link
Contributor

@Alathreon Alathreon commented Aug 5, 2023 •
edited by Zabuzard
Loading

  • JShell feature added

  • Added option to get the snippets of another user

  • Refactored JShell eval into its own class

  • Changed RateLimiter so it's a global limiter and not a per user limiter + merged user and oneOffSession together

  • Added context action for running java code

  • Fixing sonar wranings for jshell

Config

The config was changed, the following has been introduced:

"jshell": {
    "baseUrl": "<put_jshell_rest_api_url_here>",
    "rateLimitWindowSeconds": 10,
    "rateLimitRequestsInWindow": 3
}

@Alathreon
Feature/jshell from fork (#869)
f0a93b5 
* JShell feature added

* Added option to get the snippets of another user

* Refactored JShell eval into its own class

* Changed RateLimiter so it's a global limiter and not a per user limiter + merged user and oneOffSession together

* Added context action for running java code

* Fixing sonar wranings for jshell
@Alathreon Alathreon requested review from a team as code owners August 5, 2023 16:31
@Alathreon Alathreon linked an issue Aug 5, 2023 that may be closed by this pull request
Migrate JShell Bot #91
Closed
@Alathreon Alathreon changed the title Feature/jshell from fork (#869) Feature/jshell (#869) Aug 5, 2023
@Alathreon Alathreon changed the title Feature/jshell (#869) Feature/jshell Aug 5, 2023
Zabuzard
Zabuzard requested changes Aug 8, 2023
View reviewed changes
application/config.json.template Outdated Show resolved Hide resolved
application/src/main/java/org/togetherjava/tjbot/config/Config.java Outdated Show resolved Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/code/EvalCodeCommand.java Outdated Show resolved Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/jshell/JShellCommand.java Outdated Show resolved Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/jshell/JShellCommand.java Outdated Show resolved Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/jshell/JShellCommand.java Outdated Show resolved Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/jshell/JShellCommand.java Outdated Show resolved Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/jshell/backend/JShellApi.java Show resolved Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/utils/RateLimiter.java Outdated Show resolved Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/utils/RequestFailedException.java Show resolved Hide resolved
@Zabuzard
Copy link
Member

Zabuzard commented Aug 8, 2023

please fix the sonar warnings as well, thanks

Zabuzard
Zabuzard requested changes Aug 9, 2023
View reviewed changes
application/src/main/java/org/togetherjava/tjbot/features/code/CodeMessageHandler.java Outdated Show resolved Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/jshell/JShellCommand.java Outdated Show resolved Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/jshell/JShellCommand.java Outdated Show resolved Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/jshell/JShellCommand.java Outdated Show resolved Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/jshell/ResultRenderer.java Outdated Show resolved Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/jshell/backend/JShellApi.java Outdated Show resolved Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/jshell/backend/dto/JShellResult.java Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Alathreon Alathreon merged commit 03b1112 into develop Aug 11, 2023
9 checks passed
@Alathreon Alathreon deleted the feature/jshell branch August 11, 2023 11:56
@Zabuzard Zabuzard mentioned this pull request Sep 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SquidXTV SquidXTV SquidXTV approved these changes

@Zabuzard Zabuzard Zabuzard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate JShell Bot
3 participants
@Alathreon @Zabuzard @SquidXTV