Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TCP_common.c #2387

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

xzhdream
Copy link

@xzhdream xzhdream commented Aug 8, 2023

func: add_priority
priority_queue_start is a list for read, priority_queue_end is just as a tag


This change is Reviewable

func: add_priority
priority_queue_start is a list for read, priority_queue_start is just as a tag
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 10.00%. Comparing base (a1e2458) to head (79d1bbf).
Report is 269 commits behind head on master.

Files with missing lines Patch % Lines
toxcore/TCP_common.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2387      +/-   ##
==========================================
+ Coverage    9.98%   10.00%   +0.02%     
==========================================
  Files         141      141              
  Lines       32530    32530              
==========================================
+ Hits         3247     3255       +8     
+ Misses      29283    29275       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf
Copy link
Member

iphydf commented Aug 16, 2023

Can you explain a bit more what this change is doing?

@xzhdream
Copy link
Author

xzhdream commented Aug 22, 2023

Can you explain a bit more what this change is doing?

it is only a logical problem. priority_queue_start is used to read.
if TCP_Priority_List *p = con->priority_queue_start
then if (p != nullptr) { p->next = new_list; } else { con->priority_queue_start = new_list; }
can work as its goal

@iphydf iphydf added this to the v0.2.20 milestone Nov 10, 2023
@TokTok TokTok deleted a comment from CLAassistant Dec 20, 2023
@JFreegman
Copy link
Member

@xzhdream How does this change current behaviour? As far as any of us are aware, this function already works as intended. Are we mistaken?

@iphydf iphydf modified the milestones: v0.2.20, v0.2.21 Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants