Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add tox_options_set_savedata, deprecate old functions. #2840

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

refactor: Add tox_options_set_savedata, deprecate old functions.

1038738
Select commit
Loading
Failed to load commit list.
Open

refactor: Add tox_options_set_savedata, deprecate old functions. #2840

refactor: Add tox_options_set_savedata, deprecate old functions.
1038738
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable succeeded Feb 1, 2025 in 11s

3 checks passed!

Status: PASS

Details

✔️ Validator: TITLE

  • ✔️ All the requisite validations passed for 'or' option
    Input : refactor: Add tox_options_set_savedata, deprecate old functions.
    Settings : {"or":[{"must_include":{"regex":"^(feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+$","message":"Semantic release conventions must be followed."}},{"must_include":{"regex":"^Bump [^ ]* from [^ ]* to [^ ]*$","message":"Dependabot PRs are exempt from semantic release conventions."}}]}

✔️ Validator: COMMIT

  • ✔️ Your commit messages met the specified criteria
    Input : refactor: Add tox_options_set_savedata, deprecate old functions.

This one is simpler than the existing tox_options_set_savedata_data and
therefore safer for clients to use. It will either fail (no change) or
succeed (allocation+copy).

Also setting data size without setting data makes no sense, so that
function is now deprecated.
Settings : {"do":"commit","message":{"regex":"^((feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+|Bump [^ ]* from [^ ]* to [^ ]*)","message":"Semantic release conventions must be followed."}}

✔️ Validator: DESCRIPTION

  • ✔️ description must exclude '\[ \]'
    Input : This one is simpler than the existing tox_options_set_savedata_data and
    therefore safer for clients to use. It will either fail (no change) or
    succeed (allocation+copy).

Also setting data size without setting data makes no sense, so that
function is now deprecated.


This change is Reviewable

Settings : {"must_exclude":{"regex":"\\\\[ \\\\]","message":"There are incomplete TODO task(s) unchecked."}}