Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Mark events/dispatch headers as experimental. #2842

Merged
merged 1 commit into from
Jan 25, 2025

cleanup: Mark events/dispatch headers as experimental.

8799bea
Select commit
Loading
Failed to load commit list.
Merged

cleanup: Mark events/dispatch headers as experimental. #2842

cleanup: Mark events/dispatch headers as experimental.
8799bea
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable succeeded Jan 25, 2025 in 0s

3 checks passed!

Status: PASS

Details

✔️ Validator: TITLE

  • ✔️ All the requisite validations passed for 'or' option
    Input : cleanup: Mark events/dispatch headers as experimental.
    Settings : {"or":[{"must_include":{"regex":"^(feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+$","message":"Semantic release conventions must be followed."}},{"must_include":{"regex":"^Bump [^ ]* from [^ ]* to [^ ]*$","message":"Dependabot PRs are exempt from semantic release conventions."}}]}

✔️ Validator: COMMIT

  • ✔️ Your commit messages met the specified criteria
    Input : cleanup: Mark events/dispatch headers as experimental.

We're already installing these, but they have been experimental all this
time. We should not install them until we're really done with them.
Settings : {"do":"commit","message":{"regex":"^((feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+|Bump [^ ]* from [^ ]* to [^ ]*)","message":"Semantic release conventions must be followed."}}

✔️ Validator: DESCRIPTION

  • ✔️ description must exclude '\[ \]'
    Input : We're already installing these, but they have been experimental all this time. We should not install them until we're really done with them.

This change is Reviewable

Settings : {"must_exclude":{"regex":"\\\\[ \\\\]","message":"There are incomplete TODO task(s) unchecked."}}