feat(Debug): Allow user to limit the copied log size. #476
+1,370
−149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
enhancement
iphydf
force-pushed
the
limit-log
branch
5 times, most recently
from
18b68db to
b4976d5
Compare
iphydf
force-pushed
the
limit-log
branch
3 times, most recently
from
8009274 to
f79a4a2
Compare
iphydf
changed the title
We usually don't need a very long history to debug issues. This protects us from having to look at unnecessarily old logs and protects users from sharing too much of their activity history. The default of 1000 is chosen generously because it'll likely be limited by log line age first. The 1000 protects us from enormous logs.
iphydf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We usually don't need a very long history to debug issues. This protects us from having to look at unnecessarily old logs and protects users from sharing too much of their activity history.
The default of 1000 is chosen generously because it'll likely be limited by log line age first. The 1000 protects us from enormous logs.
This change is