chore: Clean up some warning flags; add wiki.

.bazelrc

@@ -380,7 +380,8 @@ build --per_file_copt='//toxic[:/]@-Wno-documentation'
 # Ignore super donators stuff. It's verbatim. We compile it, but don't care about cleanliness.
 build --per_file_copt='//c-toxcore/super_donators@-Wno-comma,-Wno-extra-semi-stmt,-Wno-unreachable-code-return,-Wno-unused-result'
 
-# Tests
+# Tests (Google Test) use global constructors and destructors and some other
+# slightly unclean things.
 build --per_file_copt='_bench\\.(cc|cpp)$@-Wno-weak-vtables,-Wno-zero-as-null-pointer-constant'
 build --per_file_copt='_(test|bench)\\.(cc|cpp)$@-Wno-global-constructors,-Wno-exit-time-destructors'
 build --per_file_copt='_test\\.(cc|cpp)$@-Wno-c99-extensions'
@@ -409,7 +410,6 @@ build --per_file_copt='\\.pb\\.cc$@-Wno-missing-prototypes'
 build --per_file_copt='\\.pb\\.cc$@-Wno-weak-vtables'
 
 # TODO(iphydf): Fix these soon.
-build --per_file_copt='//c-toxcore@-Wno-sign-compare'
 build --per_file_copt='//qtox@-Wno-error=switch'
 build --per_file_copt='//toxins/toxvpn@-Wno-format'
 build --per_file_copt='//toxins/toxvpn@-Wno-unaligned-access'
@@ -418,13 +418,11 @@ build --per_file_copt='//toxins/toxvpn@-Wno-zero-as-null-pointer-constant'
 build --per_file_copt='//toxins/toxvpn@-Wno-zero-length-array'
 
 # TODO(iphydf): Fix these.
-build --per_file_copt='//c-toxcore@-Wno-unused-but-set-variable'
 build --per_file_copt='//experimental@-Wno-switch-enum'
 build --per_file_copt='//experimental@-Wno-used-but-marked-unused'
 build --per_file_copt='//jvm-toxcore-c@-Wno-error=switch'
 build --per_file_copt='//jvm-toxcore-c@-Wno-global-constructors,-Wno-exit-time-destructors'
 build --per_file_copt='//qtox@-Wno-comma'
-build --per_file_copt='//qtox@-Wno-deprecated'
 build --per_file_copt='//qtox@-Wno-documentation'
 build --per_file_copt='//qtox@-Wno-documentation-unknown-command'
 build --per_file_copt='//qtox@-Wno-double-promotion'

.gitmodules

@@ -91,6 +91,9 @@
 [submodule "website"]
 	path = website
 	url = https://github.com/TokTok/website
+[submodule "wiki/qtox.wiki"]
+	path = wiki/qtox.wiki
+	url = https://github.com/TokTok/qtox.wiki
 [submodule "zig-toxcore-c"]
 	path = zig-toxcore-c
 	url = https://github.com/TokTok/zig-toxcore-c

third_party/BUILD.ffmpeg

@@ -4,7 +4,6 @@ load("@toktok//third_party/yasm:build_defs.bzl", "asm_library")
 COPTS = [
     "-DPIC",
     "-DZLIB_CONST",
-    "-DHAVE_AV_CONFIG_H",
     "-Iexternal/ffmpeg/libavcodec",
     "-I$(GENDIR)/third_party/ffmpeg/platform",
 ] + select({
@@ -369,7 +368,7 @@ cc_library(
         "libavdevice/timefilter.c",
         "libavformat/tls.c",
     ],
-    copts = COPTS,
+    copts = COPTS + ["-DHAVE_AV_CONFIG_H"],
     deps = [
         ":headers",
         "@toktok//third_party/ffmpeg:config",
@@ -378,7 +377,7 @@ cc_library(
 
 objc_library(
     name = "ffmpeg_osx_objc",
-    copts = COPTS,
+    copts = COPTS + ["-DHAVE_AV_CONFIG_H"],
     non_arc_srcs = [
         "libavdevice/avfoundation.m",
         "libavfilter/vf_coreimage.m",
@@ -413,7 +412,7 @@ cc_library(
         "libavutil/hwcontext_videotoolbox.c",
         "libavutil/pixdesc.c",
     ],
-    copts = COPTS,
+    copts = COPTS + ["-DHAVE_AV_CONFIG_H"],
     linkopts = [
         "-lpthread",
         "-liconv",
@@ -446,7 +445,7 @@ cc_library(
         "libavutil/hwcontext_d3d11va.c",
         "libavutil/hwcontext_dxva2.c",
     ],
-    copts = COPTS,
+    copts = COPTS + ["-DHAVE_AV_CONFIG_H"],
     linkopts = [
         "/DEFAULTLIB:Bcrypt.lib",
         "/DEFAULTLIB:D3D11.lib",
@@ -481,7 +480,7 @@ cc_library(
         "libavdevice/xcbgrab.c",
         "libavformat/unix.c",
     ],
-    copts = COPTS,
+    copts = COPTS + ["-DHAVE_AV_CONFIG_H"],
     linkopts = [
         "-lpthread",
         "-lm",
@@ -516,7 +515,7 @@ cc_library(
         "libavdevice/v4l2-common.c",
         "libavdevice/v4l2enc.c",
     ],
-    copts = COPTS,
+    copts = COPTS + ["-DHAVE_AV_CONFIG_H"],
     linkopts = [
         "-lpthread",
         "-ldl",
@@ -2652,7 +2651,7 @@ cc_library(
         "libavutil/imgutils.h",
         "libswscale/swscale.h",
     ],
-    copts = COPTS,
+    copts = COPTS + ["-DHAVE_AV_CONFIG_H"],
     includes = ["."],
     visibility = ["//visibility:public"],
     deps = [
@@ -2672,14 +2671,16 @@ cc_library(
     name = "fftools",
     srcs = [
         "fftools/cmdutils.c",
-        "fftools/ffmpeg.c",
+        "fftools/ffmpeg_dec.c",
         "fftools/ffmpeg_demux.c",
+        "fftools/ffmpeg_enc.c",
         "fftools/ffmpeg_filter.c",
         "fftools/ffmpeg_hw.c",
         "fftools/ffmpeg_mux.c",
         "fftools/ffmpeg_mux_init.c",
         "fftools/ffmpeg_opt.c",
-        "fftools/ffprobe.c",
+        "fftools/ffmpeg_sched.c",
+        "fftools/ffplay_renderer.c",
         "fftools/objpool.c",
         "fftools/opt_common.c",
         "fftools/sync_queue.c",

tools/git-remotes

@@ -149,6 +149,10 @@ our %REPOS = (
       repo 'iphydf',
       repo 'qtox',
    }],
+   'wiki/qtox.wiki' => ['qtox.wiki', {
+      upstream => 'toktok',
+      repo 'qtox',
+   }],
    'spec' => ['spec', {
       upstream => 'toktok',
       repo 'iphydf',

tools/git_modules_test.pl

@@ -3,78 +3,88 @@
 use strict;
 use warnings FATAL => 'all';
 
-my ($GITMODULES, $GITREMOTES, @PROJECTS) = @ARGV;
+my ( $GITMODULES, $GITREMOTES, @PROJECTS ) = @ARGV;
 
 sub parse_gitmodules {
-   my ($file) = @_;
-
-   my %mods;
-   my $cur;
-
-   open my $fh, '<', $file or die "$file: $!";
-   while (<$fh>) {
-      if (m|^\[submodule "(.*)"\]$|) {
-         $cur = $mods{$1} = {};
-      } elsif (m|^\tpath = (.*)|) {
-         $cur->{path} = $1;
-      } elsif (m|^\turl = https://github.com/TokTok/(.*)|) {
-         $cur->{repo} = $1;
-      }
-   }
-
-   my %repos = map { $mods{$_}{path} => $mods{$_}{repo} } keys %mods;
-   \%repos;
+    my ($file) = @_;
+
+    my %mods;
+    my $cur;
+
+    open my $fh, '<', $file or die "$file: $!";
+    while (<$fh>) {
+        if (m|^\[submodule "(.*)"\]$|) {
+            $cur = $mods{$1} = {};
+        }
+        elsif (m|^\tpath = (.*)|) {
+            $cur->{path} = $1;
+        }
+        elsif (m|^\turl = https://github.com/TokTok/(.*)|) {
+            $cur->{repo} = $1;
+        }
+    }
+
+    my %repos = map { $mods{$_}{path} => $mods{$_}{repo} } keys %mods;
+    \%repos;
 }
 
 sub parse_gitremotes {
-   package GitRemotes;
-   use File::Basename;
-
-   do "./$GITREMOTES";
-
-   my %repos;
-
-   sub is_subsubmodule {
-      my ($dir) = @_;
-      while ($dir ne '.' and $dir ne '/') {
-         $dir = dirname $dir;
-         return 1 if $GitRemotes::REPOS{$dir};
-      }
-      0
-   }
-
-   for my $path (keys %GitRemotes::REPOS) {
-      # Filter out submodules of submodules. They do appear in git-remotes, but
-      # not in .gitmodules, because they appear in the submodule's .gitmodules,
-      # which we're not testing.
-      next if is_subsubmodule $path;
-      $repos{$path} = $GitRemotes::REPOS{$path}[0];
-   }
-
-   \%repos
+
+    package GitRemotes;
+    use File::Basename;
+
+    do "./$GITREMOTES";
+
+    my %repos;
+
+    sub is_subsubmodule {
+        my ($dir) = @_;
+        while ( $dir ne '.' and $dir ne '/' ) {
+            $dir = dirname $dir;
+            return 1 if $GitRemotes::REPOS{$dir};
+        }
+        0;
+    }
+
+    for my $path ( keys %GitRemotes::REPOS ) {
+
+       # Filter out submodules of submodules. They do appear in git-remotes, but
+       # not in .gitmodules, because they appear in the submodule's .gitmodules,
+       # which we're not testing.
+        next if is_subsubmodule $path;
+        $repos{$path} = $GitRemotes::REPOS{$path}[0];
+    }
+
+    \%repos;
 }
 
-my $modules = parse_gitmodules $GITMODULES;
-my $remotes = parse_gitremotes $GITREMOTES;
+my $modules  = parse_gitmodules $GITMODULES;
+my $remotes  = parse_gitremotes $GITREMOTES;
 my %projects = map { $_ => undef } @PROJECTS;
 
 # Check that .gitmodules doesn't have more modules than git-remotes.
-for my $repo (sort keys %$modules) {
-   die ".gitmodules contains submodule '$repo' not listed in %REPOS in $GITREMOTES\n"
+for my $repo ( sort keys %$modules ) {
+    die
+".gitmodules contains submodule '$repo' not listed in %REPOS in $GITREMOTES\n"
       unless exists $remotes->{$repo};
 }
+
 # And vice-versa.
-for my $repo (sort keys %$remotes) {
-   die "$GITREMOTES contains repository '$repo' not listed in .gitmodules\n"
+for my $repo ( sort keys %$remotes ) {
+    die "$GITREMOTES contains repository '$repo' not listed in .gitmodules\n"
       unless exists $modules->{$repo};
 }
+
 # Check that tools/BUILD.bazel knows about all our projects.
-for my $repo (sort keys %$modules) {
-   die ".gitmodules contains submodule '$repo' not listed in projects in tools/BUILD.bazel\n"
+for my $repo ( grep { !m|^wiki/.*\.wiki$| } sort keys %$modules ) {
+    die
+".gitmodules contains submodule '$repo' not listed in projects in tools/BUILD.bazel\n"
       unless exists $projects{$repo};
 }
+
 # And it doesn't have too many.
-for my $repo (sort @PROJECTS) {
-   die "tools/BUILD.bazel lists project '$repo' that isn't listed in .gitmodules"
+for my $repo ( sort @PROJECTS ) {
+    die
+      "tools/BUILD.bazel lists project '$repo' that isn't listed in .gitmodules"
       unless exists $modules->{$repo};
 }