BT-235: ERC2612 - Add ERC-20 Permit function compatibility #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SRL132
reviewed
Dec 20, 2024
SRL132
reviewed
Dec 20, 2024
SRL132
approved these changes
Jan 17, 2025
| } | ||
|
|
||
| // solhint-disable-next-line func-name-mixedcase | ||
| function __TokenPermit_init(string memory name) internal { |
There was a problem hiding this comment.
need to find a solution without this init, because it has to work on updated contracts that didn't get initialized from the constructor. Or you can probably have something that checks if it is initialized already and calls __TokenPermit_init() in case it was not initialized at deployment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tokeny.atlassian.net/browse/BT-235