removing comments

ENV_VARS.md

@@ -58,8 +58,10 @@ Agents can be configured using environment variables:
 | TA_METRICS_CONFIG_LOGGING_ENABLED | Set this flag to print metrics in logs |
 | TA_METRICS_CONFIG_LOGGING_FREQUENCY | Set the frequency at which metrics should be printed. Examples are '1s', '2m', '3h'. Default value is 30m |
 | TA_METRICS_CONFIG_EXPORTER_ENABLED | When `true` metrics will be exported as spans from libtraceable |
+| TA_METRICS_CONFIG_EXPORTER_SECURE | Use HTTPS for calls to TPA |
 | TA_METRICS_CONFIG_EXPORTER_ENDPOINT | For reporting the spans |
-| TA_METRICS_CONFIG_EXPORTER_EXPORT_INTERVAL_MS | Max interval for calls to Collector |
-| TA_METRICS_CONFIG_EXPORTER_EXPORT_TIMEOUT_MS | Max timeout for calls to Collector |
+| TA_METRICS_CONFIG_EXPORTER_CERT_FILE | Cert file for connecting to TPA over HTTPS |
+| TA_METRICS_CONFIG_EXPORTER_EXPORT_INTERVAL_MS | Max interval for calls to TPA |
+| TA_METRICS_CONFIG_EXPORTER_EXPORT_TIMEOUT_MS | Max timeout for calls to TPA |
 | TA_ENVIRONMENT | Represents the environment name of agent |
 | TA_AGENT_TOKEN | Represents the agent token to be used by the agent |

gen/go/proto/v1/config.proto

@@ -164,7 +164,7 @@ message MetricsConfig {
     EndpointMetricsConfig endpoint_config = 2;
     // config for printing metrics in logs
     MetricsLogConfig logging = 3;
-    // config for exporting metrics to Traceable Platform
+    // config for exporting metrics to Traceable Platform Agent
     MetricsExporterConfig exporter = 4;
 }
 
@@ -203,15 +203,17 @@ message EdgeDecisionServiceConfig {
   repeated google.protobuf.StringValue exclude_path_regexes = 5;
 }
 
-// TODO, not making this generic. This is exclusively for goagent, others should fill these values in from reporting config.
-// Once hypertrace proto is merged into this one, this should be replaced with reporting config of hypertrace proto
 message MetricsExporterConfig {
   // when `true` metrics will be exported as spans from libtraceable
   google.protobuf.BoolValue enabled = 1;
+  // use HTTPS for calls to TPA
+  google.protobuf.BoolValue secure = 2;
   // endpoint for reporting the spans
-  google.protobuf.StringValue endpoint = 2;
-  // max interval for calls to Collector
-  google.protobuf.Int32Value export_interval_ms  = 3;
-  // max timeout for calls to Collector
-  google.protobuf.Int32Value export_timeout_ms  = 4;
+  google.protobuf.StringValue endpoint = 3;
+  // cert file for connecting to TPA over HTTPS
+  google.protobuf.StringValue cert_file = 4;
+  // max interval for calls to TPA
+  google.protobuf.Int32Value export_interval_ms  = 5;
+  // max timeout for calls to TPA
+  google.protobuf.Int32Value export_timeout_ms  = 6;
 }