Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-48260: Update to fix environment name conflict #28

Closed
wants to merge 2 commits into from
Closed

ENG-48260: Update to fix environment name conflict #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af42bdf
removing conflicting environment name in AgentConfig
thugrock7 Aug 9, 2024
72500f1
renaming message to AgentHostAttributes
thugrock7 Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ENV_VARS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,4 @@ Agents can be configured using environment variables:
| TA_METRICS_CONFIG_ENDPOINT_CONFIG_LOGGING_FREQUENCY | Set the frequency at which metrics should be printed. Examples are '1s', '2m', '3h'. Default value is 30m |
| TA_METRICS_CONFIG_LOGGING_ENABLED | Set this flag to print metrics in logs |
| TA_METRICS_CONFIG_LOGGING_FREQUENCY | Set the frequency at which metrics should be printed. Examples are '1s', '2m', '3h'. Default value is 30m |
| TA_ENVIRONMENT | Represents the environment name of agent |
| TA_AGENT_HOST_ATTRIBUTES_ENVIRONMENT | Represents the environment name of agent |
9 changes: 7 additions & 2 deletions gen/go/proto/v1/config.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ message AgentConfig {
Javaagent javaagent = 7;
LogConfig logging = 8;
MetricsConfig metrics_config = 9;
// represents the environment name of agent
google.protobuf.StringValue environment = 10;
// AgentHostAttributesConfig contains attributes that are specific to agent
AgentHostAttributesConfig agent_host_attributes = 10;
}

// Opa covers the options related to the mechanics for getting Open Policy Agent configuration file.
Expand Down Expand Up @@ -182,3 +182,8 @@ message RateLimitConfig {
// set the span type for rate limited spans
SpanType span_type = 6;
}

message AgentHostAttributesConfig {
// represents the environment name of agent
google.protobuf.StringValue environment = 1;
}
Loading
Loading