Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11 bug fix #915

Merged
merged 2 commits into from
Dec 4, 2019
Merged

IE11 bug fix #915

merged 2 commits into from
Dec 4, 2019

Conversation

zdlm
Copy link
Contributor

@zdlm zdlm commented Dec 4, 2019

When we use ts.io, tradeshift-ui and ts-element polyfill together, will show a null exception in IE11. This is the fix for that

Unable to get property 'getPrototypeOf' of undefined or null reference

@Tradeshift/TradeshiftUI

Fixes issue #

… will show a null exception in IE11. This is the fix for that
@zdlm zdlm requested a review from a team as a code owner December 4, 2019 09:30
@@ -388,10 +388,14 @@ gui.Action = (function using(confirmed, chained) {
* @param {Window} win Remote window
* @param {String} uri target origin
* @param {String} key Spiritkey of xdomain IframeSpirit (who will relay the action)
* SetTimeout because the bug in IE11. It will show null exception when you remove
* an iframe.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add the information about the Web Component Polyfill. Because it only get triggered when that polyfill exist.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@Kian-Esmaeilpour
Copy link
Contributor

#916

@Kian-Esmaeilpour Kian-Esmaeilpour self-assigned this Dec 4, 2019
@Kian-Esmaeilpour Kian-Esmaeilpour merged commit 0f0db73 into master Dec 4, 2019
@Kian-Esmaeilpour Kian-Esmaeilpour deleted the lza/ie11-iframe-remove branch December 4, 2019 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants