Merge pull request #140 from Tradeshift/race

Allow subclasses to hold off on commands while not idle

ts-reaktive-actors/src/main/java/com/tradeshift/reaktive/actors/AbstractStatefulPersistentActor.java

@@ -75,6 +75,14 @@ protected java.time.Duration getPassivateTimeout() {
         return context().system().settings().config().getDuration("ts-reaktive.actors.passivate-timeout");
     }
 
+    /**
+     * Returns whether the asynchronous part of a Handler for this command is currently in progress
+     * (and, hence, further commands would currently be stashed if sent to this actor)
+     */
+    protected boolean isCommandInProgress() {
+        return !idle;
+    }
+
     @SuppressWarnings("unchecked")
     @Override
     public Receive createReceive() {
@@ -147,9 +155,6 @@ protected boolean canHandleCommand(C cmd) {
      * Must only be invoked if {@link #canHandleCommand(Object)} has returned true for this command.
      */
     protected void handleCommand(C cmd) {
-        // FIXME We need to uphold command ordering for the same sender (just like akka does for normal messages).
-        // Hence, we need to stash subsequent messages from the same sender, while one message from that sender is still
-        // being piped.
         pipe(handlers.handle(state, cmd), context().dispatcher()).to(self(), sender());
     }
 

ts-reaktive-replication/src/main/java/com/tradeshift/reaktive/replication/actors/ReplicatedActor.java

@@ -154,6 +154,8 @@ protected Receive justCreated() {
                 getContext().become(master());
                 if (receive.onMessage().isDefinedAt(c)) {
                     receive.onMessage().apply(c);
+                } else {
+                    log.warning("Unhandled first write command: {}", c);
                 }
             })
             .match(Query.EventEnvelope.class, e -> {