Properly end a worker if not all timestamps are in the stream #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are seeing workers not always being ended, and that may be for two reasons: 1. The current MaterializerActor never sends events with t=endTimestamp to MaterializerWorkers, yet the latter requires t=endTimestamp to conclude the worker is done. 2. The exact endTimestamp might not even occur in the source stream, if it's sparse enough. So, instead, we should wait until we've progressed _past_ the endTimestamp, finish that exact timestamp, and then MaterializerWorkers should conclude that we are done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing workers not always being ended, and that may be for two
reasons:
to MaterializerWorkers, yet the latter requires t=endTimestamp to
conclude the worker is done.
it's sparse enough.
So, instead, we should wait until we've progressed past the
endTimestamp, finish that exact timestamp, and then MaterializerWorkers
should conclude that we are done.
However, the added tests in this commit actually succeed fine on the current code. More investigation is needed.