Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: timeout as parameter #82

Merged
merged 2 commits into from
Jan 9, 2024
Merged

feat: timeout as parameter #82

merged 2 commits into from
Jan 9, 2024

Conversation

tribiec
Copy link
Contributor

@tribiec tribiec commented Jan 9, 2024

This PR adds a timeout parameter to the perform method on RequestService, so users can now configure how many milliseconds until receiving a timeout from the Request.

Copy link
Contributor

@mvarlic mvarlic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@isabellaahc isabellaahc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@tribiec tribiec merged commit e359962 into master Jan 9, 2024
7 checks passed
@tribiec tribiec deleted the feat/timeout-as-parameter branch January 9, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants