Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 Update to windows 0.58 #236

Merged
merged 4 commits into from
Jul 15, 2024
Merged

🪟 Update to windows 0.58 #236

merged 4 commits into from
Jul 15, 2024

Conversation

Jasper-Bekkers
Copy link
Member

Depends on #233

Cargo.toml Outdated Show resolved Hide resolved
Copy link
Member

@MarijnS95 MarijnS95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit to require version 0.58 for the examples because it contains two breaking changes. Also dropped the Cargo.toml version bump so that we can publish it cleanly later.

Indeed the fork-release should have used a - suffix in the version.

@Jasper-Bekkers Jasper-Bekkers enabled auto-merge (squash) July 10, 2024 01:43
@Jasper-Bekkers Jasper-Bekkers requested a review from MarijnS95 July 10, 2024 01:44
Jasper-Bekkers and others added 4 commits July 15, 2024 16:11
Since the `windows 0.58` upgrade our crate still supports `windows` all
the way back to `0.53`, but the examples use some breaking API changes
that require `0.58`.  This means, also because of using `windows` in the
public API, that it must only be paired with `gpu-allocator` on `0.58`.
@Jasper-Bekkers Jasper-Bekkers merged commit a35343f into main Jul 15, 2024
26 checks passed
@MarijnS95 MarijnS95 deleted the windows-0.58 branch July 15, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants