Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Allocation::name() getter #257

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Firestar99
Copy link

What the title says, nothing special. I don't want to store yet another copy of the same string, it would be nice if I could just query it instead.

@MarijnS95
Copy link
Member

Should the PR title be prefixed with vulkan: or are you intending to add this to the other backends (dx12 and Metal) as well?

@MarijnS95 MarijnS95 changed the title add Allocation::name getter add Allocation::name() getter Dec 24, 2024
@Jasper-Bekkers
Copy link
Member

Looking at this, does anyone know why it's name: Option<Box<str>> and not name: Option<String>?

@MarijnS95
Copy link
Member

MarijnS95 commented Jan 9, 2025

@Jasper-Bekkers that should be #70, which explains it's a minor reduction in struct size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants