Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 280 (Drawer-like behavior for the sidebar) #281

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

andreacampi
Copy link
Member

In the second commit, we may want to add the sidebar-drawer-active class to the chrome instead.

@scottkellum
Copy link
Contributor

Looks good. If a smaller grid is selected when the sidebar is activated does it jump back up to the larger grid when the sidebar is put away or is the width bug still happening?

@andreacampi
Copy link
Member Author

No, it doesn't grow again. That's unfortunate...

@scottkellum
Copy link
Contributor

Is it ok if we leave this for a little while until we can address some of the implications of it? Because it is an optional flag, maybe it is ok for now.

@andreacampi
Copy link
Member Author

No problem, I use a private build of Treesaver anyway. I just wanted to get it out there.

@c-kick
Copy link

c-kick commented Apr 23, 2012

I can confirm that with the right CSS, it actually does grow back. Trick being that every class that sets the grid width (based on the amount of columns) needs a 'max-width' setting equal to (or one pixel below, to avoid scoring faults) the width of the next, with the exception of the last. E.g:

(considering a column width of 280px, having a margin of 20px in case of multiple columns)


.grid.cols-1 {
    max-width: 579px;
    width: 280px; }
.grid.cols-2 {
    max-width: 879px;
    width: 580px; }
.grid.cols-3 {
    width: 880px; }

Therefore it would be very worthwhile merging this in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants