-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mypy type errors fix #324
Mypy type errors fix #324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a few minor issues I found with this PR but overall well done! Thanks for the contribution, would appreciate some changes made though :)
New commit with requested changes have been pushed. |
If you approve recent changes I think we should merge those changes since this issue is open to all to participate so we need to avoid cases when someone else will try to handle errors that have been already resolved in this PR. |
So I think I'm going to hold off on correcting errors until #339 will be implemented. |
Thank you |
Thanks for the wait. PR #339 has been merged |
Ok, tomorrow I'll resolve conflicts and as soon as this PR will be merged I will proceed with work on the rest of errors. |
Amazing, sounds good |
# Conflicts: # backend/decorators.py # settings/prod_settings.py
Regarding changes. If there will come features in the future that will be using Also what do you think about moving |
All views are login required, we just use middleware instead of @login_required |
As for the second part of the comment, I'm not too sure. I feel like the utils file should be for logic, rather than type definitions. Wherever the HTMX request is we could add a user object to that? And then add a second one if we use htmx without login required? We could talk more on discord if you'd like, may be easier |
Yes sure, my username is domejko_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing PR, thank you!
Description
Fixed all type errors in settings/ folder reducing there number from 384 to 369 errors.
Edit:
Part of files in backend/ also have been fixed and errors count is reduced to 354.
Edit:
Mypy error count reduced from 354 to 313.
Created utils/ folder, refactored utils.py to different files and updated imports accordingly.
Added new subclass of HttpRequest reduce type errors as suggested in django-stubs documentation.
Edit:
event_bridge_scheduler
inside the function to call when needed due toChecklist
djLint-er on any new code
(checks
will
fail without)
changes
What type of PR is this?
Added/updated tests?
Related PRs, Issues etc