Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixed when creating receipt and deleting the receipts #326

Merged
merged 7 commits into from
Apr 12, 2024

Conversation

atulanand25
Copy link
Contributor

Description

I have validated and tweaked the creation and deletion of the receipts to ensure it works as expected.

Added the has_access method in the modal for receipts to use while deleting the receipts

Checklist

  • Ran the Black Formatter and
    djLint-er on any new code
    (checks
    will
    fail without)
  • [x ] Made any changes or additions to the documentation where required
  • Changes generate no new warnings/errors
  • New and existing unit tests pass locally with my
    changes

What type of PR is this?

  • 🐛 Bug Fix

Added/updated tests?

  • 🙋 no, because I need help

atanand2 and others added 5 commits April 12, 2024 17:54
…ion for iam_client Initialization

Description:
I encountered an issue where the initialization of
iam_client was causing an error during server startup. To address this issue, I have modified the code to lazily initialize iam_client only when it is needed. This prevents the error from occurring during server startup.

Changes Made:

Refactored the code to initialize iam_client within functions where it is needed, instead of initializing it globally.
Implemented lazy initialization logic to ensure that iam_client is initialized only when it is accessed for the first time.
Verified that the changes resolve the server startup error and do not introduce any new issues.
Description:
I have validated and tweaked the creation and deletion of the receipts to ensure it works  as expected.

Added the has_access method in the modal for receipts to use it when deleting the receipts
Error handling when reading from database for receipts
…nfiguration for iam_client Initialization"

This reverts commit 83447d9.
backend/api/receipts/delete.py Outdated Show resolved Hide resolved
@TreyWW TreyWW merged commit c26cafd into TreyWW:main Apr 12, 2024
17 checks passed
@atulanand25 atulanand25 deleted the Receipt_deletion_and_creation_fix branch April 12, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants