Code Changes views/clients/create.py #356
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TreyWW
reviewed
Apr 27, 2024
TreyWW
approved these changes
Apr 27, 2024
|
TreyWW
requested changes
Apr 28, 2024
backend/views/core/clients/create.py
Outdated
| @@ -9,14 +9,14 @@ | |||
| def create_client(request: HtmxHttpRequest): | |||
| if request.method == "GET": | |||
| return render(request, "pages/clients/create/create.html") | |||
|
|
|||
There was a problem hiding this comment.
Could you run black ./ or py manage.py lint black for me please. Thanks!
|
I suggest next time running tests locally, there's been quite a few issues with this PR. https://docs.strelix.org/MyFinances/contributing/setup/#test-and-lint |
devenderbutani21
force-pushed
the
code-cleanup-db
branch
from
ff0ac3a
to
8d23ed2
Compare
|
Apologies I force pushed some stuff the other day and it broke a few bits. I'll revert it now |
TreyWW
requested changes
May 21, 2024
| messages.error(request, "Failed to create client - an unknown error occurred") | ||
| return redirect("clients dashboard") | ||
| def create_client_instance(user, client_details): | ||
| organization = user.logged_in_as_team if user.logged_in_as_team else None |
There was a problem hiding this comment.
This needs to support adding customers under an individual user aswell as organisation
|
Apologies for the really delayed response. If you could fix up the bug that I addressed above that would be much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made code changes to views/clients/create.py