Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invoice not found error msg for user #382

Merged
merged 3 commits into from
May 31, 2024
Merged

Invoice not found error msg for user #382

merged 3 commits into from
May 31, 2024

Conversation

Domejko
Copy link
Contributor

@Domejko Domejko commented May 23, 2024

Description

Regarding #377

  • In case when user will try to delete non existent invoice he will get now a error message that "Invoice Not Found" and page will refresh removing non existent invoice fro view.
  • Reformatted docs/overrides/partials/integrations/analytics/ custom.html with djLint due to pre-commit error.

Checklist

  • Ran the Black Formatter and
    djLint-er on any new code
    (checks
    will
    fail without)
  • Made any changes or additions to the documentation where required
  • Changes generate no new warnings/errors
  • New and existing unit tests pass locally with my
    changes

What type of PR is this?

  • 🐛 Bug Fix
  • ♻️ Code Refactor

Added/updated tests?

  • 🙅 no, because they aren't needed

Related PRs, Issues etc

@TreyWW TreyWW merged commit 6ecd63e into TreyWW:main May 31, 2024
12 checks passed
@Domejko Domejko deleted the invoice-notfound-msg branch July 9, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TreyWW TreyWW TreyWW approved these changes

Assignees
No one assigned
Labels
awaiting-response
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: No message for the user when trying to delete not existing Invoice
2 participants
@Domejko @TreyWW