Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code scanning alert no. 20: URL redirection from remote source #519

Merged
merged 1 commit into from
Oct 19, 2024
Merged

Fix code scanning alert no. 20: URL redirection from remote source #519

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions backend/core/views/auth/login.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
from django.shortcuts import render, redirect
from django.urls import resolve, reverse
from django.urls.exceptions import Resolver404
from django.utils.http import url_has_allowed_host_and_scheme
from django.utils.decorators import method_decorator
from django.views import View
from django.views.decorators.http import require_GET, require_POST
Expand Down Expand Up @@ -76,10 +77,13 @@ def login_manual(request: HttpRequest):
messages.warning(request, "You have been requested by an administrator to change your account password.")
return redirect("settings:change_password")

try:
resolve(redirect_url)
return redirect(redirect_url)
except Resolver404:
if url_has_allowed_host_and_scheme(redirect_url, allowed_hosts=None):
try:
resolve(redirect_url)
return redirect(redirect_url)
except Resolver404:
return redirect("dashboard")
else:
return redirect("dashboard")


Expand Down
Loading