-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVA Protocol improvements #63
Conversation
@InvictusRMC @rmadhwal Can we fix this PR please? |
@synctext yes, in my testing this seemed to work consistently with medium sized files (3 - 10 MB) |
@rmadhwal : as you proposed this change back in April 2022: lets merge this PR first. @KoningR please review and comment this PR. Is there a conflict with your recent PR work? |
@InvictusRMC there's a discrepancy between the version of Kotlin this patch was pushed on and its current version causing the tests to fail since TestCoroutineScope seems to have been deprecated after 1.6, I'll push a new patch with the fixed tests |
Thank you; I appreciate it. Meanwhile, I pushed some suppression so that the build at least passes 😄 |
This PR addresses issues with the EVA protocol dicussed in Tribler/trustchain-superapp#101
The implemented changes are:
The changes worked fine in my local testing using the EVA protocol with Freedom of Computing, please let me know if you require an APK to verify them
@synctext @drew2a