Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated default dll import path to be '.' #1296

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Updated default dll import path to be '.' #1296

merged 2 commits into from
Jun 14, 2024

Conversation

qstokkink
Copy link
Collaborator

@qstokkink qstokkink commented Jun 14, 2024 •
edited
Loading

This PR:

  • Adds a retry to claim the REST ports of the identity validation scripts.
  • Updates the dll import path to be . instead of __file__ for the unit tests.

This allows downstream projects, where __file__ is not located in . to work.

@qstokkink
Copy link
Collaborator Author

validate

@qstokkink qstokkink changed the title WIP: Updated default dll import path to be '.' READY: Updated default dll import path to be '.' Jun 14, 2024
@qstokkink qstokkink marked this pull request as ready for review June 14, 2024 13:16
@qstokkink qstokkink mentioned this pull request Jun 14, 2024
Merged
@qstokkink qstokkink changed the title READY: Updated default dll import path to be '.' Updated default dll import path to be '.' Jun 14, 2024
@qstokkink qstokkink merged commit 548e78a into Tribler:master Jun 14, 2024
6 checks passed
@qstokkink qstokkink deleted the upd_libsodium_dll_loc branch June 14, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egbertbouman egbertbouman egbertbouman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qstokkink @egbertbouman