Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update localservices to use httprouter from test suite #10

Merged
merged 4 commits into from
Dec 2, 2016

Conversation

tgross
Copy link
Contributor

@tgross tgross commented Nov 15, 2016

For #7

This updates our test suite to be compatible with the httprouter library that was added to gocommon. This results in a much more manual and explicit test suite setup because of some of the funky limitations in that library (which is really designed for performance, not testing... but to back that library our now would have ripple effects to our Terraform providers which I'd rather not take on now).

cc @misterbisson @chorrell

Test runs:

$ go test ./...
ok      github.com/joyent/gomanta       0.007s
?       github.com/joyent/gomanta/localservices [no test files]
ok      github.com/joyent/gomanta/localservices/hook    0.009s
ok      github.com/joyent/gomanta/localservices/manta   0.053s
ok      github.com/joyent/gomanta/manta 0.265s

$ go test ./manta -live
ok      github.com/joyent/gomanta/manta 8.790s

@tgross
Copy link
Contributor Author

tgross commented Nov 15, 2016

I've added support for Wercker CI to this PR as well. Successful builds look like this: https://app.wercker.com/joyent/gomanta/runs/build/582b74ba2e4c060100c22b60

@tgross tgross merged commit 41c8bc3 into TritonDataCenter:master Dec 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant