📦 externalized portal locales #21945
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no issue All locales were previously included in the main bundle, even though at most 1 locale is used. By separating out the locales, we can reduce the bundle size by ~60%: | | raw | gzip | | ------------------- | --------------- | --------------- | | Before | 1,542.72 kB | 365.86 kB | | After | 546.38 kB | 156.29 kB | | Savings | 996.34 kB (65%) | 209.57 kB (57%) | | After (+1 locale) | 564.48 kB | 162.54 kB | | Savings (+1 locale) | 978.24 kB (63%) | 203.32 kB (56%) | - Added an async i18n factory that fetches locales on-demand - Implemented in a separate browser entrypoint for tree shaking - Created an i18n singleton/cache to avoid downloading the same locale multiple times - Allowed the locale fetch root to be overridden via `data-locale-root` - Added `vite-plugin-ghost-i18n` (plugin.js) in `@tryghost/i18n` to: - Emit each portal locale as a build asset - Minify the locales (using `JSON.stringify`) - Prevent rewriting `import.meta.url`
3 Modes:
- `opt-in` generates `${ns}-no-locales.min.js` with async locales and `${ns}.min.js` with inlined locales
- `opt-out` generates `${ns}-locales.min.js` with inlined locales and `${ns}.min.js` with async locales
- `solo` generates `${ns}.min.js` with async locales
`import.meta.url` is not available unless the script is executing in a module context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no issue
All locales were previously included in the main bundle, even though at most 1 locale is used.
By separating out the locales, we can reduce the bundle size by ~60%:
data-locale-rootvite-plugin-ghost-i18n(plugin.js) in@tryghost/i18nto:JSON.stringify)import.meta.urlGot some code for us? Awesome 🎊!Backwards Compatibility
The new plugin (
vite-plugin-ghost-i18n) supports incremental adoption, based onstability. Since this hasn't been tested at-scale, Portal's stability is currentlyopt-in.{ns}-no-locales.min.js{ns}-locales.min.js