New login #7
Closed
New login #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/FelixSFD/chatexchange.git into feature/6-replace-openid Conflicts: src/main/java/fr/tunaki/stackoverflow/chat/StackExchangeClient.java
|
Hey @FelixSFD. I don't see why |
|
I've fixed the account creation and logging in to chat.SE in my fork. If you have time, you can copy the code from there. Otherwise we have to release our fork on Maven as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the library to support login without OpenID (#6). It's basically an implementation of the idea Sam posted in our channel.
API changes
None of the public APIs was changed. Bot owners won't need to update their code. They'll just need to import the new version of the library as soon as it's released.
Internal changes
Deprecated methods
StackExchangeClient.SEOpenIdLogin()StackExchangeClient.siteLogin()New properties
StackExchangeClient.emailandStackExchangeClient.passwordStackExchangeClient, because we have to use the credentials on every site where we want to join a roomStackExchangeClient.loggedInHostsCompatibility with hosts
At the moment, only sites that are already using the new login-form are compatible. (for example Stack Overflow, AskUbuntu and meta.SE)
stackexchange.comseems not to work yet, since it's still using OpenID.