Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Rb 5271 blacklisting and global ratelimiting #2

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Rb 5271 blacklisting and global ratelimiting #2

wants to merge 15 commits into from

Conversation

MichaelAEden
Copy link

@MichaelAEden MichaelAEden commented Jan 31, 2020 •
edited
Loading

Changes:

  • Since we are trying to replace Remembackend's dependency on RateLimiter with too-many-bears, we'll have to add some minimal blacklisting logic to maintain the same behaviour in Remembackend
  • The HaveIBeenPwned API has a strict ratelimiting of 1 request/1500ms with a sliding window, so we need to implement some form of global ratelimiting
  • Refactoring and added tests

Note the blacklisting changes are NOT backwards compatible, so I bumped the version.

@MichaelAEden MichaelAEden self-assigned this Jan 31, 2020
@MichaelAEden
Copy link
Author

Turns out I have a few more changes to make before I'm ready for review.
I'll remove reviews for now to prevent spamming everyone with emails.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@MichaelAEden MichaelAEden

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MichaelAEden